Xinye Tao

Good catch, feel free to file a fixing PR. This particular issue could be easily detected by clippy, but there're too many of them and we never get the time...

Nice catch! Our unit tests didn't catch it because it will only be non-null when sub-compaction is involved. The start is set here: https://github.com/tikv/rocksdb/blob/ce0ea61aecd53ac02a0e7da2b166961c7d98650a/db/compaction/compaction_job.cc#L542-L550 And the `boundaries_` is set here:...

Hi, RocksDB log started being handled by TiKV since this PR: https://github.com/tikv/tikv/pull/7358

Looks promising, if you are interested in running it against TiKV, the build script is here: https://github.com/tikv/rust-rocksdb/blob/0a57dd2e2c3d1be9679a9ad6a3ed70dcb4b87eff/librocksdb_sys/build.rs#L128 We can add a feature flag to optionally enable it. Unfortunately our team...

What do you mean "supporting async"? AFAIK RocksDB doesn't have true async interface, and rust-rocksdb is only a binding library, it cannot and will not implement an async runtime on...

I see there're many real errors aside from warnings being converted to errors. We don't currently have gcc-11 CI so the testing is quite lacking. You are welcome to fix...

I've located the issue to be in the liveness check: https://github.com/rust-lang/rust/blob/56694b04532cc0dec6e2f577135da3513e856923/compiler/rustc_passes/src/liveness.rs#L875-L896 Here a diverge point sits inside a *conditional* block, but this information is lost when calling `propagate_through_expr`, which then...

cc @overvenus @Connor1996

> Seems duplicated with #58. From the looks of it, #58 doesn't support async sleep and runtime async callback. This PR supports them, but doesn't support specifying a compile-time async...

> > I can't figure out an elegant way to unify async and sync version of fail_point!(name, callback). And I'm reluctant to go with #58 and make all fail_point!(name, callback)...