Xinye Tao

I think it's caused by file recycling (`SinglePipe::recycled_files`), some of obsolete log files will be kept around for future writes to reuse. After https://github.com/tikv/raft-engine/pull/310, those files no longer use a...

Did you disable it explicitly? It is enabled by default for a while now.

To avoid constantly rebuilding the cache, we use a specific nightly toolchain in our CI. That's why these issues are not caught early: https://github.com/tikv/raft-engine/blob/7a436eae40a6b62371123c96941e058b7fe52b63/.github/workflows/rust.yml#L22 Feel free to fix these issues,...

To be future-proof, I'll keep the issue here even though #244 will fix it temporarily. Contributions are always welcome if you find the CI toolchain is outdated.

@ustc-wxy format and clippy failed.

https://github.com/tikv/raft-engine/pull/286#discussion_r1118822597 is still not addressed. Is there any confusion? > shouldn't use unwrap. `expect` is the same as `unwrap` except with some message. What I meant is the code shouldn't...

No plan yet. But I think it would be trivial to implement once this task (and parallel writing) is completed.

@sticnarf Sadly, we will default enable it for TiDB Cloud dev tier. Can't change it now.

It's a good idea. I already have a PR that merge the file location field of multiple entries into one u32 (https://github.com/tikv/raft-engine/pull/208). We just need to move the entry offset...

@v0y4g3r Sorry for the delay. To move forward this feature, I'll first need to (1) polish https://github.com/tikv/raft-engine/pull/208 with feature gate, then (2) you can propose a change that fully embeds...