Timothy Bish

Results 18 comments of Timothy Bish

There doesn't appear to be any tests here to validate that this is still an issue, many fixes have gone into the codebase since this was opened.

> Does this need to have validation on allowed class types added? Just wondering if there are any potential security concerns like we recently had with the OpenWire protocol not...

> @tabish121 - Do you have any thoughts on this PR (or know who else would know?) > > I'm not too familiar with the UTF-8 encoding stuff or the...

> @azotcsit - Here is the link to the protonj code where they have a custom impl https://github.com/apache/qpid-proton-j/blob/main/proton-j/src/main/java/org/apache/qpid/proton/codec/WritableBuffer.java > > I think the idea is you don't know the length...

> LGTM, I'm just not sure if squash_commit_message should be `PR_TITLE_AND_DESC` because I read a bad feedback on it, see https://issues.apache.org/jira/browse/IGNITE-24959 I have similar concerns here on the quality of...

This one needs rebased and touched up before it can be checked as main has quite a few changes including deprecating methods in SimpleString the tests added are still using.

> Does [ac1b483](https://github.com/apache/activemq-artemis/commit/ac1b483cb449b72b5eaa2b4c6547bc7cdea92dae) factor in here at all? I believe it came up in the context of federation, but seems like it could overlap and looks like it went in...

I ran this through CI and it seems to break quite a few tests, so probably more work to do here. I checked into some of the failed AMQP tests...

If you need to open five "no jira" PRs for cleaning up unit tests, then you probably need a JIRA for cleaning up unit tests.

I would suggest waiting until 4.2 is released and the feature becomes part of netty proper and has the testing behind it to ensure a reasonable user experience along with...