Timothy Bish

Results 18 comments of Timothy Bish

> So all of this was already discussed and I don't see how this PR addresses any of those concerns It does not.

Commit message is misleading as it only focuses on improving the test execution time not the MQTT code itself.

Seeing a repeatable failure in test:`org.apache.activemq.artemis.tests.integration.mqtt5.MQTT5Test#testResumeSubscriptionsAfterRestart` ``` org.opentest4j.AssertionFailedError: expected: but was: at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:158) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:139) at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:69) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:41) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35) at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:195) at org.apache.activemq.artemis.tests.integration.mqtt5.MQTT5Test.testResumeSubscriptionsAfterRestart(MQTT5Test.java:235) ```

Core Federation is essentially unmaintained (and under tested) and should probably be marked as deprecated for removal in a future release. Given that I'd say adding management APIs and code...

Closing for now as this appears to have been abandoned

The original intention was to define this API as disjoint from the Messages as that is not really necessary at this level, and given the changes are adding Message only...

Closing this as inactive, can re-open once code changes are actually made

I would suggest making this a draft and working through the issue some more until it can be determined how to best address the underlying problem.