Tomáš Mráz
Tomáš Mráz
> the thing is that the `ctx == NULL` check is implemented by PROV_LIBCTX_OF() macro. No, not really. The problematic `ctx == NULL` check is on the line 161. I...
I do not think this is needed as the alternative fix was merged.
> All allocations are happening taking place in file `bn_lib.c` in a function called `bin2bn`. The current call sequence to allocate (for example s->srp_ctx.a) are as follows > # File...
We will need to rebase the branch to resolve the CI failures.
Merged to the feature branch. Thank you for your contribution.
Merged to the master, 3.6 and 3.5 branches. Thank you for your contribution.
> With this change in mind should I continue to make changes based on the reviews for the crypto implementation or wait for an update from BBB, and focus on...
I've converted it into a draft until the implementation is replaced with a standard version.
> Adding the missing header include brought up new errors in the Windows builds > > ``` > bn_gcd.c > ..\crypto\bn\bn_gcd.c(659): error C2220: the following warning is treated as an...
> I'm in favour of having this done in 4.0. > > Cc: [@mattcaswell](https://github.com/mattcaswell) , [@t8m](https://github.com/t8m), [@t-j-h](https://github.com/t-j-h) +1