Tomáš Mráz
Tomáš Mráz
> what issue is this addressing? I am trying to reproduce this failure: https://github.com/openssl/openssl/actions/runs/11292741961/job/31409362706
Merged to the master and 3.4 branches. Thank you for the reviews.
You cannot do this for public interfaces because the `bool,` `false,` and `true` identifiers would frequently collide with other software. We would have to use `OSSL_BOOL,` `OSSL_FALSE,` `OSSL_TRUE.`
Also if you think the existing API calls should be converted to use this type, this would be 4.0 material.
Setting 4.0.0 milestone as IMO we do not want to introduce this without bigger API rehash thing.
> Hi again [@openssl/committers](https://github.com/orgs/openssl/teams/committers), any chance to get this into 4.0? I think it is too late. However we could decide we start using bool for new API calls.
> This we could have done anytime, already just after this was brought up in early 2022. Not really, as it requires moving to C99 which we did not do...
ping @MegaManSec there are comments.
Squashed, applied clang-reformat and merged to the master branch. Thank you for your contribution.
I do not think we need re-approvals. New coding style check passes.