Tomáš Mráz comments

Results 1511 comments of


                                            Tomáš Mráz

potential NULL pointer dereference due to glitch ossl_quic_stream_has…

Would it be possible to add a testcase?

Is the way how you handle $CROSS_COMPILE and $CC really correct?

Yeah, if we get CC from environment with an absolute path, we definitely should not prepend CROSS_COMPILE.

SSL_inject_net_dgram() should return result of ossl_quic_demux_inject()

@Sashan please also `git commit --amend` the commit message.

SSL_inject_net_dgram() should return result of ossl_quic_demux_inject()

Still a typo in the commit message.

SSL_inject_net_dgram() should return result of ossl_quic_demux_inject()

@Sashan can you please rebase this?

SSL_inject_net_dgram() should return result of ossl_quic_demux_inject()

Please rebase this

SSL_inject_net_dgram() should return result of ossl_quic_demux_inject()

Merged to the feature branch. Thank you.

Public symbols removed during 3.x upgrade

None of these symbols except EC_GFp_nistpXXX_method are public, i.e. published in public headers of OpenSSL. As for the 3 missing public symbols, are you sure you had enable-ec_nistp_64_gcc_128 argument with...

Random byte generation provider API

We are clearly after feature freeze for 3.4. So this has to go into 3.5.

TLS1.3 with brainpool version incompatibility

If both versions support TLS-1.3 they must never choose older version. If they cannot agree on supported groups connection failure is inevitable.