openssl icon indicating copy to clipboard operation
openssl copied to clipboard

SSL_inject_net_dgram() should return result of ossl_quic_demux_inject()

Open Sashan opened this issue 1 year ago • 3 comments

This got introduced by 595288251bb (QUIC APL: Ensure APL functions use correct prologue)

Sashan avatar Oct 10 '24 08:10 Sashan

@Sashan any chance of a better title for this PR and commit?

tom-cosgrove-arm avatar Oct 10 '24 09:10 tom-cosgrove-arm

@Sashan please also git commit --amend the commit message.

t8m avatar Oct 10 '24 09:10 t8m

Still a typo in the commit message.

t8m avatar Oct 10 '24 18:10 t8m

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

openssl-machine avatar Nov 14 '24 00:11 openssl-machine

@Sashan can you please rebase this?

t8m avatar Nov 15 '24 17:11 t8m

can you rebase this so its a bit easier to review please?

FWIW, the change to the return code looks fine to me, just needs rebasing, ack when thats done

nhorman avatar Nov 15 '24 18:11 nhorman

Please rebase this

t8m avatar Nov 22 '24 13:11 t8m

failed ci is related to https://github.com/openssl/project/issues/930, being handled there

nhorman avatar Nov 23 '24 02:11 nhorman

Merged to the feature branch. Thank you.

t8m avatar Nov 25 '24 13:11 t8m