Charles Lombardo

Results 46 comments of Charles Lombardo

@JosJuice Just took some time to try and get the custom covers working again. I'm not happy with the implementation I have here, but this is the only way I've...

The splash screen now appears the same across all android versions. Turns out you could make the splash screen appear under API 31 by using windowSplashScreenAnimatedIcon and not android:windowSplashScreenAnimatedIcon... But...

Oh, I also just discovered that the splash screen will not appear on devices below API 23. I'm not surprised... but I'm still ok with that.

@MayImilae and @JosJuice Let me know if there's anything I could improve here

I like the suggestion. I'll look into it, but this is done in part to account for a wider variety of theme colors. ![image](https://user-images.githubusercontent.com/14132249/173198503-b86d6ea0-1c7d-4b02-8da6-8c3971fbea66.png) Here's an example with a Material...

Running Google's theme builder, we loose a bit of the original color but I'll leave it here. PR - ![home (Small)](https://user-images.githubusercontent.com/14132249/173199627-0b1b8840-36ac-4e8a-b146-a35a84badb40.png) Theme Builder - ![image](https://user-images.githubusercontent.com/14132249/173199489-5e4851f6-773b-4279-963e-59236edd1b3c.png) The buttons look better though...

Just adjusted the colors to more closely follow the generated ones. The changes are reflected in the top comment.

> I like it! A few quibbles here and there (like the text colour already mentioned) but overall I think this is an improvement. However, I have a request. Could...

Ah ok, I could make the default follow the previous colors with less of a pastel look but offer the the pastel one as an additional option.

> Though of course, that as a default with pastel as an option would be great. Or at least an option to get that kind of non-pastel look. I'm wanting...