Charles Lombardo

Results 46 comments of Charles Lombardo

I really like how the new dark theme colors look and as long as I remove the pastel color from dialogs, I would keep it as is.

Here's what the new defaults look like Light - ![lightDemo gif](https://user-images.githubusercontent.com/14132249/177084075-5b4bd1ad-e792-4172-83eb-a6c21122d8bc.gif) Dark - ![darkDemo gif](https://user-images.githubusercontent.com/14132249/177084085-2d1668cc-d291-4b93-82d3-1743beffdefd.gif)

Just found a couple more old dialog implementations **Converting Dialog** Old - ![convertingold](https://user-images.githubusercontent.com/14132249/177627405-fb64139d-dc30-478f-8e7b-277459b2d1f0.png) New - ![convertingnew](https://user-images.githubusercontent.com/14132249/177627515-afb52032-dfc6-48d2-a0e8-b70a1abea244.png) **Settings Loading Dialog** Old - ![settingsold](https://user-images.githubusercontent.com/14132249/177627494-0139d675-412e-4838-bbd7-6023d0533043.png) New - ![settingsnew](https://user-images.githubusercontent.com/14132249/177627481-7505b009-09a8-441a-b85b-a580b29c4c1b.png)

Also just figured that if this dialog is cancelable, we should have a clear cancel button. ![anotherupdatehelpme](https://user-images.githubusercontent.com/14132249/177629600-843db23c-302a-4d60-b01c-84d43c3cacb5.png)

Just quickly brought this PR up-to-date again with the new addition of XLink Kai in #10625 and their contribution of InputStringSettings. Here's what it looks like - ![image](https://user-images.githubusercontent.com/14132249/183131130-d6bcbc85-0767-4a05-b555-a9366e77f7fe.png)

After getting some much-needed polish in, I feel much more confident about this PR going up for review. After some discussion with @JosJuice I've also worked out a plan for...

> Could you please show video recordings of the collapsing top app bar? Not collapsing, medium collapsing, and large collapsing. I'm not an android user so I'm having a hard...

> This is just my personal opinion and not my opinion as the Android maintainer, but that behavior just seems weird to me. I've never seen an app behave like...

It starts in the pulled down state

Here's a better example https://user-images.githubusercontent.com/14132249/185750816-13d38c67-ca2c-427e-8025-70b9d98cbde8.mp4