Shinichi Tanaka comments

Results 32 comments of


                                            Shinichi Tanaka

[X11] Create windows with a parent window

All checks have passed! It's truly ready for review :confetti_ball:

[X11] Create windows with a parent window

This PR followed the HEAD of master. Including document updates.

[X11] Create windows with a parent window

What does this PR stop? I’ll try to resolve that if I can.

[X11] Create windows with a parent window

Oh... It make sense.

[X11] Create windows with a parent window

Sorry I did my project... I can do this PR starting this week end maybe.

[X11] Create windows with a parent window

Status reporting. I'm working visualized child window creations and found a bug https://github.com/rust-windowing/winit/pull/2363. This PR depends that PR so I'm waiting some reviews.

[X11] Create windows with a parent window

Visualizing child window is finished. I've done for all review points, so this PR is ready for review. But CI fails in many platforms...

[X11] Create windows with a parent window

Now CI fails in like i386-linux. I'm not familiar with X11, [`XID` sometimes typedefs as a pointer](https://github.com/freedesktop/xorg-xserver/search?q=typedef+xid)...? CI fails in i386-linux because [`XID` is not u32](https://github.com/rust-windowing/winit/runs/7205283569?check_suite_focus=true). To solve it roughly,...

[X11] Create windows with a parent window

Now CI on Linux is passed. I don't know why Windows CI fail.

[X11] Create windows with a parent window

hmm... @dhardy may I remove softbuffer related code from this PR? Original example in this PR does not visualize each child windows but can demonstrate how to create child windows....