Takayuki Matsuoka
Takayuki Matsuoka
As another possible solution, we'll be able to use the following inline extern C style ``` extern "C" void my_public_func(void); ``` We can also define it as a macro ```...
I think questions for & vs && are our minor faq. So we may be able to add comments for these tricky/cryptic conditions.
Hi @Teylusu Honestly, we have no idea at all so far. Because lz4 doesn't use `___chkstk_ms` directly. 1. How did you hit this error? 2. Could you provide actual reproduce...
Hi @Sewer56, thanks for the report. I also confirmed this issue with the following code: https://gist.github.com/t-mat/c13ee550df5cf013dfa32c166b8fbb38 Since the dictionary size is greater than `LZ4HC_HASHSIZE` (4), I think it should work....
I couldn't reproduce this issue. We need more information. Especially build envrionment, actual reproducing procedure and its log. Here's my experiment (Supposed) Reproducing commands ``` export PS1="lz4-1515 \w$ " cd...
> Does using a cli command "lz4 -1" use lz4_compress_fast() and "lz4 -9" use lz4_compress_HC()? Yes. Actually, the `lz4` CLI doesn't use the public function directly. But basically it uses...
> So the lz4 CLI doesn't really use the above 2 functions I mentioned? `lz4` CLI uses them when [`-l` (legacy)](https://github.com/lz4/lz4/blob/v1.10.0/programs/lz4.1.md?plain=1#L209) modifier argument is provided. - `-l1` (legacy format, fast)...
It seems we should fix the following line v1.10.0 (FAIL) https://github.com/lz4/lz4/blob/v1.10.0/lib/Makefile#L126 v1.9.4 (OK) https://github.com/lz4/lz4/blob/v1.9.4/lib/Makefile#L116 Due to the difference of `--out-implib`, the following `COPY` commands in `appveyor.yml` fail to copy them...
> Given that a 3rd-party modification silently broke the package builder, it could happen again in the future. Could the CI tests be updated to be able to detect such...
Hi @29039 , thanks for the report and your investigation. I put additional information here for further integration in future. Reproduction procedure ---------------------- ```bat cmd.exe cd /d "%PUBLIC%" git clone...