Takayuki Matsuoka
Takayuki Matsuoka
Hi @Mingli-Yu, thank you for sending PR. But unfortunately your PR has failed to pass our test. Also I couldn't repro your issue with `gcc-12.1`. First of all, please understand...
Hi @jrosdahl, thanks for the info! Now I can reproduce this issue with the following command: ``` CFLAGS="-Og" CC="gcc-12" make clean default # NG ``` Since I have no idea...
Intel has a public repo which contains `icc` setup for GA. https://github.com/oneapi-src/oneapi-ci I'll try it later.
> A potential work-around could be to split the source code into these dedicated units, and then have an automated build system which regenerates the "complete" amalgamated xxhash.h library, so...
> > Q. xxh-amalgum-util emits #file and #line of original file? Or xxhash.h is always "original" source? > In which cases does it make a difference ? I thought that...
I made a pair of small script for PoC. ## Demo - `amalgum-separator.py` : Separate `xxhash.h` into multiple headers. - `amalgum-expander.py` : Expand all `#include` statements in `xxhash-root.h`. And output...
I'm glad it seems we find promising direction. It also brings many further questions/issues though. > "what's the source of truth?" If we choose separation/amalgamation method, I think this is...
As for license, my idea is adding `prologue` block to amalgum utility. We introduce special comment `--amalgum--:begin-prologue` and `--amalgum--:end-prologue`. ```C // xxhash.h /* --amalgum--:begin-prologue */ /* * xxHash - Extremely...
As for dependency, we might introduce dedicated root header file for each variant. ```C /* xxhash-xxh32-root.h which produces specific variant file xxhash-xxh32.h */ #if defined (__cplusplus) extern "C" { #endif...
I've updated amalgum scripts and example `xxhash.h` which contains/supports `--amalgum--:begin-prologue` block. demo ```sh cd mkdir xxh-amalgum cd xxh-amalgum curl -LOJ https://gist.githubusercontent.com/t-mat/0614c9ed6ef7b35dcf00cd022eacfa92/raw/f0a54688f30d5ce0516d8cc7523a8c6a859afee1/amalgum-expander.py curl -LOJ https://gist.githubusercontent.com/t-mat/0614c9ed6ef7b35dcf00cd022eacfa92/raw/f0a54688f30d5ce0516d8cc7523a8c6a859afee1/amalgum-separator.py curl -LOJ https://gist.githubusercontent.com/t-mat/8414155918bb7595d8c9c43dfadd6b4f/raw/12298ac6d1c0386f26eef469b5963f39b221014e/xxhash.h # Check special...