Takayuki Matsuoka

Results 99 comments of Takayuki Matsuoka

Thanks for sending PR @vsolontsov-volant, If you can, please split your PR #1190 into two PRs. I mean: - (PR-no.1): Fixed const-ness of src data pointer in lz4file and install...

I would like to see 2 versions of code for every language - "mainline" version - Standard, platform independent - Only algorithm/calculation level optimization is allowed - "hacked" version -...

Hi @pengwinsurf, Thank you for the report. Honestly, we have no idea about this error, since our CI invokes [`make test-all`](https://github.com/Cyan4973/xxHash/blob/d46fb3e5cc760ad7e3aa0e0708e9bfb930038f09/.github/workflows/ci.yml#L168-L171) for each single commit. But it also doesn't mean...

Thanks for the info. But it seems your actual error: ``` clang -O3 -Wall -Wextra -Wconversion -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security -Wvla -Wformat=2 -Winit-self -Wfloat-equal...

Please note: We don't recommend the following path for usual users as @Cyan4973 stated. Since there're hidden prerequisites/pitfalls for `test-all`, we don't recommend it for average users. (1) Please read...

[gist](https://gist.github.com/t-mat/de819af37d3dd399147a75f9af1b034e) Procedure: ``` cmd.exe cd /d "%USERPROFILE%\Documents" md lz4-issue-1386 cd lz4-issue-1386 git clone https://github.com/lz4/lz4.git cd lz4 md build\visual_studio\lz4 cd build\visual_studio\lz4 copy ..\..\VS2022\lz4\lz4.rc . curl -JOL https://gist.githubusercontent.com/t-mat/de819af37d3dd399147a75f9af1b034e/raw/build-vs2022.cmd type build-vs2022.cmd | find...

Since Visual Studio and its installer [supports `cmake`](https://learn.microsoft.com/en-us/cpp/build/cmake-projects-in-visual-studio?view=msvc-170#installation), I think requirement of `cmake` is 100% okay for them who can install Visual Studio. I believe [`vsTests`](https://github.com/lz4/lz4/tree/vsTests) made our situation far...

Hi @mylovesaber, EDIT 2024-03-31 : This is a totally wrong answer. Please take a look next post. Wrong answer In my environment, I have no issue with `musl-gcc`. `make liblz4.a`...

Sorry. I misunderstand your issue. [`BUILD_SHARED`](https://github.com/lz4/lz4/tree/2e33b0c5f75efb3fa2b110f9eaa719dbbff19c3b/lib#makefile-variables), `DESTDIR`, and `PREFIX` settings will help you. For example: ``` rm -fR ~/mylz4-issue-1387-artifact mkdir ~/mylz4-issue-1387-artifact cd git clone --depth 1 --branch v1.9.4 https://github.com/lz4/lz4.git lz4-issue-1387...