Tom Pickett

Results 7 comments of Tom Pickett

Would it be preferable to write tests using encode/decode or the read and write functions directly? As of now the tests follow the form: ```rust #[test] fn writing_arg_u8() { let...

Not sure if this is the correct issue to ask in, but is it intended for decode:: to not account for format?

I'll fix that in my changes as well.

Sorry it took a while to get back to this, I made the PR but there are still some `VaryingOperand` related encode/decode functions that don't account for formatting. I wasn't...

I made the requested changes and formatted it, this should pass the checks.

I made the most recent commit without running the full test suite or clippy, my mistake. I also found the changes that were causing most of the issues. `(u32,VaryingOperand)` and...