boa icon indicating copy to clipboard operation
boa copied to clipboard

Encode/decode testing for Argument types

Open t-h-p opened this issue 8 months ago • 1 comments

This Pull Request fixes/closes #4240.

It changes the following:

  • Adds tests for encode/decode functionality for all argument types.
  • Changes formatting for reads and writes of (VaryingOperand,i32).

t-h-p avatar Jun 16 '25 18:06 t-h-p

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.96%. Comparing base (6ddc2b4) to head (3f15298). Report is 430 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4284      +/-   ##
==========================================
+ Coverage   47.24%   52.96%   +5.72%     
==========================================
  Files         476      494      +18     
  Lines       46892    51526    +4634     
==========================================
+ Hits        22154    27291    +5137     
+ Misses      24738    24235     -503     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 04:06 codecov[bot]

I made the requested changes and formatted it, this should pass the checks.

t-h-p avatar Jun 24 '25 21:06 t-h-p

A lot of rust tests seem to be failing, have you checked why?

HalidOdat avatar Jun 26 '25 15:06 HalidOdat

I made the most recent commit without running the full test suite or clippy, my mistake. I also found the changes that were causing most of the issues. (u32,VaryingOperand) and (u32, VaryingOperand, VaryingOperand) both break a lot of tests when formatting is added, instead of using write_u32 for all variants. Now I am trying to figure out the problem.

t-h-p avatar Jun 26 '25 15:06 t-h-p