Peter Philips

Results 45 comments of Peter Philips

@Alex-D any thoughts on this? We're hitting this again because 1) we're upgrading and need to carry our manual patch over and 2) it appears Giphy changed their api again...

I think you may just need: ``` .filter(function (gifData) { - return gifData.images.downsized.url !== ''; + var downsized = gifData.images.downsized || gifData.images.downsized_medium; + return downsized.url; }) ``` Empty string is...

Curious what the holdup on this is. This breaks hard in `selenium-webdriver v4.4.0` (whereas deprecation warning in v4.1.0). ``` Failure/Error: Capybara .current_session .driver.browser .manage .logs .get(type) NoMethodError: undefined method `logs'...

Thanks for responding @dbalatero! I think this can easily be made backwards compatible: ```ruby browser = Capybara.current_session.driver.browser logs = browser.respond_to?(:logs) ? browser.logs : browser.manager.logs logs.get(type) ``` What do you think...

@kevin-brown Kindly checking in on this. We would love to see this merged and a new select2 release made. This is singlehandedly blocking our upgrade to jquery3. My company is...

@kevin-brown Hope everything is ok! Let us know how the community can support. (I had my company just become a sponsor - hope that helps :) )

Yea. Unfortunately my company is pulling their sponsorship as there hasn't been any movement. Happy to convince them to bring it back once we hear back that there will be...

Yes, it solves it temporarily. Perhaps the rspec command can be parameterized.

ok, so I set up: https://github.com/synth/travis-timecop and https://travis-ci.org/synth/travis-timecop, but its passing there. So perhaps there is something else in my application that is fudging things around. I will look more...

I've been living without a command history in my local Rails console for years, learned helplessness, I guess. Today, I had enough, and figured out it was because of Pry...