capybara-chromedriver-logger icon indicating copy to clipboard operation
capybara-chromedriver-logger copied to clipboard

Fix Selenium 4.0 deprecation message

Open rubendinho opened this issue 3 years ago • 7 comments

Fixes #34

rubendinho avatar Apr 16 '22 01:04 rubendinho

@rubendinho is there anything blocking this PR so that this issue can be resolved?

blehoux17 avatar Aug 15 '22 14:08 blehoux17

@rubendinho is there anything blocking this PR so that this issue can be resolved?

@blehoux17 I don't believe so - I don't have write permissions to this repo to merge it though.

rubendinho avatar Aug 15 '22 15:08 rubendinho

@rubendinho What will merging this to do old versions of Chromedriver? Does this need to be a breaking version change?

dbalatero avatar Aug 28 '22 00:08 dbalatero

Thanks for responding @dbalatero! I think this can easily be made backwards compatible:

browser = Capybara.current_session.driver.browser
logs = browser.respond_to?(:logs) ? browser.logs : browser.manager.logs                 
logs.get(type)

What do you think @rubendinho?

synth avatar Aug 28 '22 02:08 synth

@synth I think this should work nicely. Unfortunately, we're no longer using this library so I can't verify.

rubendinho avatar Sep 21 '22 17:09 rubendinho

Hey @dbalatero! Just bubbling this back up and tagging you as one of the contributors of this repo. Is there anything blocking this PR from being merged? I see that you 👍'd @synth's suggestion - I am wondering if you able to merge this in?

ashik-v avatar Dec 19 '22 22:12 ashik-v

@dbalatero Any update?

v-kumar avatar Feb 23 '23 10:02 v-kumar