capybara-chromedriver-logger
capybara-chromedriver-logger copied to clipboard
Fix Selenium 4.0 deprecation message
Fixes #34
@rubendinho is there anything blocking this PR so that this issue can be resolved?
@rubendinho is there anything blocking this PR so that this issue can be resolved?
@blehoux17 I don't believe so - I don't have write permissions to this repo to merge it though.
@rubendinho What will merging this to do old versions of Chromedriver? Does this need to be a breaking version change?
Thanks for responding @dbalatero! I think this can easily be made backwards compatible:
browser = Capybara.current_session.driver.browser
logs = browser.respond_to?(:logs) ? browser.logs : browser.manager.logs
logs.get(type)
What do you think @rubendinho?
@synth I think this should work nicely. Unfortunately, we're no longer using this library so I can't verify.
Hey @dbalatero! Just bubbling this back up and tagging you as one of the contributors of this repo. Is there anything blocking this PR from being merged? I see that you 👍'd @synth's suggestion - I am wondering if you able to merge this in?
@dbalatero Any update?