Peter Philips

Results 49 comments of Peter Philips

We would love this to become the official or alternatively official plugin! If not possible to add to Trumbowyg official, @mrooseboom - how would you feel about creating a separate...

Fairly easy fix: ```diff +++ b/app/assets/javascripts/3p/trumbowyg/trumbowyg.giphy.js @@ -53,10 +53,12 @@ var html = response.data .filter(function (gifData) { - return gifData.images.downsized.url !== ''; + var downsized = gifData.images.downsized || gifData.images.downsized_medium; +...

So, after some digging, there seems to be some parameter coercion fixes in grape 0.14.0 that coerce empty string parameters to nil which basically addresses the issue. I'm locked on...

Hmm. Not sure. Seems like it would be a good practice to better define behavior and not rely on grapes implementation so much. Who knows if coercion behavior will change...

> export optflags="-Wno-error=implicit-function-declaration" This worked for me with frum!

I know I'm using a non-recent version of omniauth. But looking at the relevant code in strategy.rb, it seems the bug is likely still present in recent versions. Here's the...

Ok, oddly, if i setup the mock_auth: ```ruby def mock_auth_hash OmniAuth.config.mock_auth[:microsoft_graph] = OmniAuth::AuthHash.new({ 'provider' => 'microsoft_graph', 'uid' => '123545', 'user_info' => { 'name' => 'mockuser', 'image' => 'mock_user_thumbnail_url' }, 'credentials'...

This issue is still alive and well today in 2021. The nested entity is deceivingly not a hash but `Grape::Entity::Exposure::NestingExposure::OutputBuilder` which is why it's "not consistent".

We're hitting this too, in a way. Calling `.as_json` doesn't seem to return a hash for nested entities. Oddly, calling `.to_json` will return a string that has been properly recursed...

It seems to me the simplest implementation would be your first suggestion(thats what I was thinking first anyway). All that would need to be done is to amend the logic...