Sylv

Results 99 comments of Sylv

> I added the following to the "Read parchment mappings" test and it seems to work fine, am I missing something or not testing the right method/class? As long as...

I realize what's happening. We need to be testing 1.17 mappings or higher, otherwise it's obfuscated.

This worked for me. It doesn't work with `reorderedMappings` because for whatever reason that strips `GlStateManager` of its method mappings except for its initializers. ```groovy mappings.getClass("com/mojang/blaze3d/platform/GlStateManager") .getMethod("_activeTexture", "(I)V") .getArg(0, 0,...

Unnecessary after deobfuscation, plus this is jank.

This is silly. Does anyone have an alternative driver that's maintained by more than one person? Or maybe a contributing guide so I can help make this usable? Not being...

It could also be an error (if prefixing is off) to not have overwrites.requireAnnotations set to true.

So, I've discovered an issue in the current implementation that severely over-complicates this, and that is the `/effect` command calls `LivingEntity#addEffect` and `LivingEntity#removeEffect` methods. - **So what?** Well, if I...

> why not use threadlocals to pass context down to the remove methods? That has the same issue as changing which methods are called. I don't want to break compatibility...

> > > why not use threadlocals to pass context down to the remove methods? > > > > > > That has the same issue as changing which methods...