MinecraftDev icon indicating copy to clipboard operation
MinecraftDev copied to clipboard

MC Dev Allows Accessors to Have Conflicting Names

Open sylv256 opened this issue 6 months ago • 2 comments

Minecraft Development for IntelliJ plugin version

2025.1-1.8.5

IntelliJ version

#IU-251.26094.121

Operating System

Linux protogen 6.15.2-arch1-1 #1 SMP PREEMPT_DYNAMIC Tue, 10 Jun 2025 21:32:33 +0000 x86_64 GNU/Linux

Target platform

Fabric, Mixins

Description of the bug

The MC Dev plugin does not warn about invalid Accessor names (not prefixing them with modid$).

See https://github.com/FabricMC/community/pull/182 and the Fabric Discord server for more lengthy discussion.

sylv256 avatar Jun 21 '25 14:06 sylv256

This is currently working as intended, I am wary of changing this because this is not how most mods have written their accessors, and there isn't a great reason to change that. Accessors can be merged with each other, but overwrite other methods if overwrites.requireAnnotations is false, but mcdev's template and Fabric's official template are both going to start setting that to true. We can definitely make it an option, though.

Earthcomputer avatar Jun 22 '25 00:06 Earthcomputer

It could also be an error (if prefixing is off) to not have overwrites.requireAnnotations set to true.

sylv256 avatar Jun 22 '25 14:06 sylv256