Sylv

Results 99 comments of Sylv

> > > > > why not use threadlocals to pass context down to the remove methods? > > > > > > > > > > > > That...

I'm going to do a quick refactor of the package and make a new `Context` type for the allow events.

Refactors are finished, and we have context now.

> A regular test mod to A) act as documentation and B) act as manual tests may also be helpful. Do we still want to do this? I have more...

> `ExtraModelKey`s are intended to be stored as constants, and it is intentional that `ExtraModelKey`s are compared only by identity. The `Supplier` is only meant for debug purposes. Is there...

> Can you link the context on both the issues? I've added links to the relevant mixins in both issues.

I recently changed how this is done. Now, instead of changing the texture atlas (which is highly error-prone), I swap the UVs in `BlockRenderer#processQuad`.

> Are you able to use the Fabric Rendering APIs to implement your hook without mixins? It should provide a `QuadTransform` that your mod can register to intercept the quads...

At that point I think it should just be ported to the Sodium API since Forgified FAPI already isn't very reliable version-wise.