Benas Svipas

Results 54 comments of Benas Svipas

Hi @arcticicestudio, there's still an issue with JS & TS color inconsistencies, if you want I can fix conflicts of this PR.

Also since it's related I found another issue with class initialization. As you can see in JS it's not colorized, but in TS it is.

@arcticicestudio I know you're busy and I can help you. If needed I can solve these issues and submit a PR, I can even try to make screenshots before ->...

@arcticicestudio Created a PR: https://github.com/arcticicestudio/nord-visual-studio-code/pull/142

Also, found a bug with `meta.brace.round` this scope was missing, and if you take a look at colors of `()` function calls, you will see they are `#d8dee9` instead of...

Found issue with `meta.brace.square` too similar as mentioned above and pushed a new commit to a PR. I guess right now everything is OK and there will be no problems...

Hi @arcticicestudio do you want me to fix conflicts mentioned in comments? I'm asking to know if this PR is still relevant.

It also unfolds if you do "Organize Imports", so seems like any action related with imports unfolds even though setting is `"editor.foldingImportsByDefault": true`

@jrieken Maybe I can help to implement this? If yes, could you help me to point to some examples, places to look into?

@RyanCavanaugh I see @a-tarasyuk created a PR with fix: https://github.com/microsoft/TypeScript/pull/51093