Cosmetic changes

[svipas]

• Rename nord.json to nord-color-theme.json. It would show color palette, warnings/errors, etc. when the file is opened.
• Remove editorActiveLineNumber.foreground it's deprecated in favor of editorLineNumber.activeForeground.
• Replace deprecated editorWidgetBorder to editorWidget.background.
• Replace deprecated editorGroup.background to editorGroup.emptyBackground.
• Remove legacy support of notifications and increase min VS Code version to 1.21.0. I believe no one is using so old VS Code version when the current version is already 1.35.1 and soon it would be a 1.36.0.

[arcticicestudio]

Hi @svipas :wave:, thanks for your contribution :+1: Thanks for all these changes, but in order to review PRs and keep the project in a maintainable state each improvement/bug fix/feature should be submitted as a topic-focused single PR without contextual mixes. If you don't have the time to split these changes I can extract the changes into single PRs for you.

Also I've searched the documentations, but haven't found any mentions regarding the name of the color theme file (nord.json ➜ nord-color-theme.json) to enable additional development features. It this a new and currently undocumented features?

Regarding the removed notification keys: Even when the version of VS Code is long outdated and maybe not used by a lot of users anymore (but it is still possible), the keys are not affecting the performance or appearance and I'd like to support them at least until VS Code removes them completely or in theme version 1.0.0. This ensures all users have at least the chance to update to a later version.

[arcticicestudio]

I've checked some bundled and default themes and it looks like the name of the theme file is indeed an undocumented feature when suffixed with -color-theme.json. It enables JSON schema validation for VS Code's color theme API as well as color previews (color picker) for HEX colors. I guess we should adapt to the naming scheme, there will be no breaking change since the theme is identified by it's extension ID as well as the _metadata_ field in the package.json and not by the name of the theme file (which would be odd since a theme can provide multiple theme files).

[svipas]

Hi @arcticicestudio do you want me to fix conflicts mentioned in comments? I'm asking to know if this PR is still relevant.

[svengreb]

Thank you for your patience! 🙏🏼 It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the queue in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.

---

@svipas Thanks (again) for your contribution 🚀 The issue has been added to the queue to be planned in for the next iterations!