Sven-Hendrik Haase

Results 643 comments of Sven-Hendrik Haase

That makes sense. Would you like to put in a PR?

Thanks a lot! I will take an in-depth look soon. How do you think this interacts with #98? I think I would like to merge #98 first and I'm almost...

In a related note: Would you like to help me maintain this library? It's not getting enough love and could do with some better maintenance.

I merged and released #98 so this one now needs a rebase. :)

Sorry, I didn't get to it yet. It's on the top of my list!

@finnbear do you wanna give this a look and perhaps resolve the conflicts?

Oh, thanks for the update @Azkellas! We'll wait then. Sorry again for the long wait, life got busy. :(

So as I understand it, you will create a new PR? Shall we close this one then?

I prefer not squashing so long as the commits in a PR tell a story and are properly rebased. [git-absorb](https://github.com/tummychow/git-absorb) is quite helpful here.

Can you look at the [example](https://github.com/svenstaro/bvh/blob/master/examples/simple.rs) and check whether that gives you results? Also, running the tests should work.