Sven-Hendrik Haase

Results 640 comments of Sven-Hendrik Haase

Is there any chance you could cut down the PR into smaller chunks? I realize you did a lot of refactoring but are there perhaps any smaller chunks to make...

Hey, how are we looking here? Do you want to fix and then we can see how to get this integrated? If you like, I can even make you co-maintainer.

Well if we can somehow do this in small incremental PRs that would be ideal but I can understand if you don't want to go down that path but it...

I'd certainly appreciate contributions! However, please try to split it up to one PR per shape if you can as that makes reviewing easier.

Holy cow. Yeah it would be absolutely great if you could upstream your work! :)

I think having this kind of feature would be excellent and I'd happily accept a PR.

That might be pretty cool but I don't see myself implementing this anytime soon. However, I'd accept a PR about it.

Oh crap, you're right. I didn't . I'll take a look, sorry!