SJ
Without digging into the code too much (details are less important to me right now), this is a +1 from me. I'm a fan of making plugins/APIs easy, even at...
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
@tdyas We've discussed selecting the C or C++ compiler based on file extensions, but we would also need a workflow around compiling .c files using a C++ compiler (which I...
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
> Just have the user specify C++ tool names for the C-related tool names option? > Re (2), this would also imply creation of Objective-C and other targets per every...
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
In thinking about the compiler vs extension problem, while thinking about it further and reviewing my repos - I think it's perfectly reasonable to default to the expected compilers, but...
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
> Re: cpp_sources vs c_sources, I think this depends on how much the different tools are going to work with both C and C++. For example, test runners, formatters, linters....
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
> I don't think I'm following that. What do you mean "more than just sources"? I'm not sure either. I'm trying to think if the libraries or binaries would ever...
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
> If you add a compiler field, then you would inspect the transitive closure for the compiler field to see if C++ was ever used. If so, use C++ linker....
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
I guess I'm having a hard time envisioning where `CompilerField.normalized_value(CCSourcesField)` would get changed in the compilation pipeline.
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
Talked to Eric in Slack to clarify - makes sense now, will reflect in codebase. Idea is that `cc_source`'s `compiler` field is where the compilation language determination happens, either added...
[internal] Adding first-party sources compilation, linking, packaging, and running to the CC backend
@tdyas @Eric-Arellano @stuhood I'm keeping this in draft while I go through and clear out TODOs, add more test coverage, and just apply some general cleanup and tweaks - which...