SJ

That's pretty cool, I'd never used tokenize before - I was thinking `ast-grep` might be a good approach, but the fewer deps, the better (granted, I'd only used ast-grep for...

@stuhood Now that the completions PR is being reviewed, will be focusing on this next Before I jump into the re-writing part, what is the canonical single `Get` re-write code?...

Alright, so having a bit too much fun with this. In my branch, I wrote a basic script to play around with how we can do this migration (outside of...

@benjyw @stuhood Cheeky bump on this one re: `concurrently?` and `what is the canonical single Get re-write code?` above. Not huge urgency, but just wanted to get some clean re-writes...

Thanks @stuhood but to clarify, I'm not entirely sure what I should replace the existing GET call to in the examples above. Would it be the same as what's in...

Some notes to self while playing around: ```python # Where @rule async def get_browser(request: BrowserRequest, open_binary: OpenBinary) -> Browser: # Transforming: browser = await Get(Browser, BrowserRequest, request.browser_request()) # Into: browser:...

@stuhood Are Digests intended to remain Gets? ``` Get(, []) -> Get(, []) -> Get(, []) -> Get(, []) -> ``` This CreateDigest isn't included: ```python leak_sandbox_path_digest = await Get(...

I ran a subset of the migration (39 files converted) - Found a circular import bug, so need to fix that before I can dig into errors. I ran into...

Another note to self. The ast.unparse function works differently for Python 3.12 and 3.11 🤦🏽 3.11 is "more correct"

@stuhood @benjyw Can I get a thumbs-up/thumbs-down on this first pass of the call-by-name on the python linters (selected these specifically, because they're easy to check if they're still working...