SJ

Results 222 comments of SJ

@stuhood Thanks for reviewing! > Positional arguments are completely ignored in @rule graph solving, which improves solving performance. Gotcha, I didn't know this was a perf improvement, I just went...

@stuhood Trying to write some integration tests to get the migrate goal up for a PR, but I'm running into trouble as the new backend I've generated isn't getting picked...

I think we're talking about different things. I'm writing tests for the migrate goal you added, with the syntax AST stuff I added - as a sanity check. I was...

I believe this ticket is complete and recently merged. The overall feature isn't complete until 2 outstanding tickets/investigations are completed, and we actually run it over the whole code-base -...

> It's too early to understand exactly where things will end up, but there is a decent chance that if uv executes on their vision, it has a legitimate chance...

@stuhood @benjyw Trying to investigate why we have no migration data for the intrinsics. As an example, there is no mention of `RemovePrefix` in the migration plan, even though those...

This feels like the missing piece of the puzzle. https://github.com/pantsbuild/pants/blob/572627fd5822f19d0b9e024aed86e44535089fd3/src/rust/engine/src/tasks.rs#L185-L196

What's the use case for a plug in providing "built-in goals" rather than regular goal rules? Feels like `BuiltinGoal` would no-longer be the correct term for these.

> I was not trying to rename BuiltinGoal with this PR though. Should I be? Probably not. But we should probably carve out a ticket/discussion about this - as once...

Man, what a swing and a miss on my part - I didn't even think about generators honestly. I guess that explains a weird artifact in the vscode plugin I...