Robert Swain

Results 309 comments of Robert Swain

For those following along, this stalled a bit as I wanted to understand from where the `-B` was coming in the transformation of the view vector to camera space. And,...

Some documentation errors: https://github.com/bevyengine/bevy/actions/runs/4658001849/jobs/8243172945?pr=5928#step:6:1700

@robtfm I feel like requiring `jpeg` is better than using more bytes in the repo, but it's not a particularly strong opinion. Good idea about '.linear.jpeg' and I guess '.linear.png',...

Also the examples failed on windows saying something about the lip falling to complete after 1009 iterations. When testing locally I did notice a little stuttering but I was doing...

I think this could be updated to use the new AssetId. And there was some feedback. It’s a shame it has to do so many lookups but if the benchmarking...

Random question - why does the shadow on the light, transparent circle _increase_ the brightness? That's not a shadow :)

Could you explain the solutions to the objectives in the PR description? It's difficult to know what the PR is doing otherwise.

Nor because of the ghosting/smearing that @DGriffin91 showed above.

@DGriffin91 what does that last example at 60Hz look like on `main`? OK, so, we all want to make progress on TAA. None of what I am writing is intended...

I think on webgl2 we had to add a workaround for the base instance index not being part of the instance index value and we had to get the base...