Sunjay Bhatia

Results 237 comments of Sunjay Bhatia

I don't have the right permissions but looks like a dependabot rebase should fix the issue at hand in https://github.com/kubernetes-sigs/gateway-api/pull/2789

Closing as a result of https://github.com/projectcontour/contour/pull/4847

haven't seen this in a while, going to remove the flake attempts

@Vishal-Chdhry - a new field should be added here: https://github.com/projectcontour/contour/blob/6c2ff107b36c25ac89770704c1c247296ff6a470/apis/projectcontour/v1/httpproxy.go#L375-L409 - you can follow the logic around CORS policies in this helper: https://github.com/projectcontour/contour/blob/6c2ff107b36c25ac89770704c1c247296ff6a470/internal/dag/httpproxy_processor.go#L1305 - for testing should add some unit...

> I'm not crazy about specifying some port info in `ContourDeployment`, because I think it belongs with the Listener logically. Right now, a user can change the Listener definitions on...

relevant to this GEP/Issue: https://github.com/kubernetes-sigs/gateway-api/issues/1521

Yes, as of 1.28.0+ Contour supports backend protocol selection with Gateway API: https://github.com/projectcontour/contour/blob/main/changelogs/CHANGELOG-v1.28.0.md#gateway-api-backend-protocol-selection

Depending on interest in this for HTTPProxy, we may want to keep this around It should be a relatively simple contribution to add the same logic in the HTTPProxy processor

Just a rough implementation whipped up, might need some improvements but for now we have something that works with the existing structure