contour icon indicating copy to clipboard operation
contour copied to clipboard

Support Service AppProtocol field

Open jpeach opened this issue 5 years ago • 9 comments

Kubernetes 1.8 adds an appProtocol field to the Service. This is an optional feature that is enabled with the ServiceAppProtocol feature gate.

We already support this concept in a Contour-specific way, so we should support this standard field in Contour too. We need to be careful how we resolve this against the equivalent field in labels and HTTPProxy.

jpeach avatar Apr 10 '20 01:04 jpeach

This parameter is now globally available in kubernetes v1.20+, is this planned to be integrated into Contour?

Thank you 👍

davinkevin avatar Oct 27 '22 08:10 davinkevin

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Feb 22 '24 00:02 github-actions[bot]

With GatewayAPI, it's now integrated, no?

davinkevin avatar Feb 25 '24 16:02 davinkevin

Yes, as of 1.28.0+ Contour supports backend protocol selection with Gateway API: https://github.com/projectcontour/contour/blob/main/changelogs/CHANGELOG-v1.28.0.md#gateway-api-backend-protocol-selection

sunjayBhatia avatar Feb 26 '24 16:02 sunjayBhatia

Depending on interest in this for HTTPProxy, we may want to keep this around

It should be a relatively simple contribution to add the same logic in the HTTPProxy processor

sunjayBhatia avatar Feb 26 '24 16:02 sunjayBhatia

Cool I can help on this while waiting for the review for other PR

lubronzhan avatar Mar 05 '24 18:03 lubronzhan

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar May 06 '24 00:05 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jul 06 '24 00:07 github-actions[bot]

up?

davinkevin avatar Jul 09 '24 15:07 davinkevin