Sunjay Bhatia

Results 237 comments of Sunjay Bhatia

> > Do we think users will need to configure this per-route stat prefix? Is there any value in making this configurable? If not we can probably get away with...

this seems more usable and now does separate the stats for different route rules we'll have to figure out a stat prefix we can generate that can express uniqueness, but...

> It's not that trivial to include the `matchCondition` in the stats. Yep agreed, especially as there can be multiple match conditions in a route and these conditions can be...

> @therealak12 , thx for your pr, i am ok with it can you clarify a bit more @izturn how do you intend to use the new stats? specifically around...

> @sunjayBhatia Based on the discussion, it seems providing per-virtual-host metrics is enough. I'd like to hear your thoughts on this. to summarize: - it looks like the "per route"...

LGTM, will leave for @skriss with last signoff

Unrelated to the topic at hand but great to see users diagnosing issues using Envoy's stats output, if youre interested in contributing in this area too please let us know!...

Thanks for making this issue @bwu-contour 👍🏽 I believe when we discussed this offline, you were interested in extracting JWT payloads to Envoy filter metadata in order to put some...

Adding that this issue needs a design, since it looks like it would be helpful to do a formal design proposal to iron out the details of this new feature/api...

Apologies, we got a bit behind reviewing the PR for this issue, bumping to 1.29.0