debing.sun

Results 96 comments of debing.sun

You can cherry-pick https://github.com/redis/redis/commit/cee6dead3c66530e8bf0b6cea455e3451d1fd0c7 and remove the codes related to keyspace events.

In fact, we can't just use raxStackPop to jump to the father and try to find the next node, because this modification confuses the structure of rax. the following example:...

Perhaps the following lua script could fit your need. ```lua local keys = redis.call("keys", "binance_btc_*") local ret = {} for i = 1, #keys do local h = redis.call("hgetall", keys[i])...

Can this code also be optimized so that `raxStackPeek` can get the offset of current child node, so that we can avoid using `raxFindParentLink` to traverse to find the position...

@michaelplaing I don't think we should remove all the oom handle, it will make this PR hard to be reviewed, I think we should just leave the oom handle for...

@michaelplaing You can use ```git revert 69d043a3b13360bd23e22a0300aac20167ac414c cd8a71a381db52b203236962f9d8877ea6372ab9```

@michaelplaing Can you provide the benchmark test result(before and after this PR), so that others know the benefit of this PR.

@michaelplaing ~~Since child_offset is uint8, if node->size is 256, it will overflow.~~ Sorry, I was wrong, the max value of `child_offset` is node->size(max 256).

@michaelplaing After re-read the codes, please forgive my mistake, the max size is 255(not 256) when node is uncompressed, so uint8 is sufficient.

@michaelplaing Hi guy, Are you still around? Any progress?