sukun
sukun
completed via #2708
It looks like this list is incomplete: https://github.com/multiformats/go-multiaddr/blob/master/net/private.go#L46 If we are discovering those addresses via identify, once we fix that list these should get filtered. However, I think it's cheap...
I agree. Whitelisting seems a lot simpler. I've raised https://github.com/multiformats/go-multiaddr/pull/235 I'm classifying NAT64 as public because as I understand, in a NAT64 system these addresses can reference public IP addresses....
Note: The fix above relies on not adding invalid addresses to the peer store. We do this for identify and dht(https://github.com/libp2p/go-libp2p-kad-dht/blob/master/dual/dual.go#L111)
I agree with your reasoning. I think you meant: >This one (64:ff9b::) -> IPv4 and IPv6 clients need to talk to an IPv6 server. The ~IPv6~ **IPv4** client is assigned...
Can we do? >Detect transitions from transient to "full" connections Can we do? >Detect transitions from transient to "full" connections (and back) via events. ~I'm not sure if we can...
I don't have a good idea on how to ensure that we collect the stream handler goroutine and then close the stream rcmgr scope if the transport stream object is...
@Stebalien I have removed `AsyncClose`. The difference between webrtc and yamux/quic is that you're relying on the transport stack to discard all the buffers when you do a Close. This...
>My objection is adding this hack to libp2p itself as this is a transport specific detail. That's a fair point. I'll open an issue to discuss.