sukun

@Stebalien >Why not just call closeAndRemoveStream immediately? I have addressed this and removed the `AsyncClose` logic. Is it fine to merge?

There's one other bug which causes failure in connection establishment: ``` 2023-10-22T06:47:19.9957753Z === RUN TestTransportWebRTC_DialerCanCreateStreamsMultiple 2023-10-22T06:47:19.9959034Z panic: test timed out after 10m0s 2023-10-22T06:47:19.9959911Z running tests: 2023-10-22T06:47:19.9960992Z TestTransportWebRTC_DialerCanCreateStreamsMultiple (9m58s) ``` https://github.com/libp2p/go-libp2p/actions/runs/6602211220/job/17934010538

Both these errors haven't happened since merging #2717 The first errors was fixed by fixing the tests. When one side closes the connection the other side sees this line when...

I am not convinced it is fixed completely. We just find it flaking less for some reason. One of the reasons why that error occurs is this https://github.com/libp2p/go-libp2p/actions/runs/8125238982/job/22214622459?pr=2722 This will...

For the failures after 10m we see. I have explained the reasoning in the PR. My current theory is. The problem is with connection state change notification being reordered. Pion...

The same error in updating ice connection states: https://github.com/pion/ice/pull/656/files

>Partial review. I might be missing something, but where is the logic which address to check next? Or is that left for the implementation of the address pipeline? Yes, that...

@master255 Do you mean `len(host.Peerstore().Peers())` is 2800? Is it possible for you to share the complete repro?

@MarcoPolo What more info would the log line provide over the libp2p_eventbus_subscriber_queue_length metric?

@marten-seemann when we say resetting a timer is expensive, do you mean anything other than cpu time taken? These benchmarks take similar time for me ``` func BenchmarkTimerReset(b *testing.B) {...