Deprecate or improve documentation for crypto.GenerateEKeyPair

Open sukunrt opened this issue 2 years ago • 2 comments

In dropping support for go1.20 I came across crypto.GenerateEKeyPair. https://github.com/libp2p/go-libp2p/blob/master/core/crypto/key.go#L129

It looks like no one is using this and some time in the past it was used for SECIO. It also has the cryptic comment Used in the identify module.

@marten-seemann @Stebalien any details you can share about this?

Feb 16 '24 17:02 sukunrt

Yeah, it was used in secio for forward secrecy. IMO, it can safely be removed and nobody's likely to care.

Feb 16 '24 19:02 Stebalien

(search of local code + grep.app revealed no users other than secio)

Feb 16 '24 19:02 Stebalien

fixed by #2711

Feb 21 '24 14:02 sukunrt