Aaron comments

Results 7 comments of


                                            Aaron

connecting prevents process from exiting

I think this is because I'm calling `client.destroy()` in the `stream.on('close')` handler. If I call `client.destroy()` in the next tick, it works. There is probably a conflicting close handler somewhere...

Avoid colons in filenames

Agreed on testing for sure, if someone with a dev env already set up would be kind enough to help there I'd be very grateful.

Avoid colons in filenames

Tyvm for the build! What's PFA?

Avoid colons in filenames

Thanks! I'm going to be afk for a few days, I'll see about testing that when I get back.

Avoid colons in filenames

Finally got back to this! There were actually a couple more functions using `get_date` that I didn't find before. It looks like `get_date` is only used for generating file names,...

use optional chaining in the type guard for greater safety

I added some more information. Please do let me know if there's any other clarification I can provide.

use optional chaining in the type guard for greater safety

Any chance of merging this?