rmkit icon indicating copy to clipboard operation
rmkit copied to clipboard

Avoid colons in filenames

Open suddjian opened this issue 1 year ago • 6 comments

Fixes #217

I haven't tested this, I'm on windows right now and don't have make. But it seems pretty straightforward.

suddjian avatar Mar 25 '24 01:03 suddjian

thanks for doing this! looks good, but worth testing before merge

raisjn avatar Mar 25 '24 02:03 raisjn

Agreed on testing for sure, if someone with a dev env already set up would be kind enough to help there I'd be very grateful.

suddjian avatar Mar 25 '24 02:03 suddjian

harmony.tar.gz

PFA the built file (had to upload as .tar.gz)

raisjn avatar Mar 25 '24 02:03 raisjn

Tyvm for the build! What's PFA?

suddjian avatar Mar 25 '24 17:03 suddjian

PFA = please find attached. sorry about the corp speak

raisjn avatar Mar 25 '24 18:03 raisjn

Thanks! I'm going to be afk for a few days, I'll see about testing that when I get back.

suddjian avatar Mar 25 '24 18:03 suddjian

Finally got back to this! There were actually a couple more functions using get_date that I didn't find before. It looks like get_date is only used for generating file names, so I decided to change the way it formats the date instead of adding an extra sanitization step. (though this is my first time working with cpython, so maybe double check that)

I've tested this last commit, all functionality appears to be working correctly.

suddjian avatar May 11 '24 21:05 suddjian