Steven Troxler

I don't have strong opinions either way. The second internal example is actually using the globals in other functions defined well above the original function, not just as persistent variables...

cc @yangdanny97 for the notebook failure, I'm pretty sure it's timing out on the duplicate publish diagnostics check because the logs show a publish diagnostics check succeeding before the timeout....

@yangdanny97, @kinto0 I think at least some of these may be reproing on trunk, maybe nondeterministically. I just observed the notebook test failure in a seemingly unrelated PR https://github.com/facebook/pyrefly/actions/runs/19606247892/job/56145548484?pr=1650 which...

I think this is effectively a contextual typing problem: for attributes defined in class bodies, we currently will use the assigned expression's inferred type even if an ancestor has an...

I think this is coming from the implicit `from builtins import *` that is part of all modules. We shouldn't include those. Interestingly I'm having trouble reproducing this - for...

Thanks for the bug report! We're currently missing exhaustiveness on match entirely, it's tracked in https://github.com/facebook/pyrefly/issues/1286 This should be done before the V1 release

@IDrokin117 The bug involved actually already has a unit test, see `test_walrus_on_first_branch_of_if` in https://github.com/facebook/pyrefly/blob/main/pyrefly/lib/test/flow.rs It's a longstanding bug but is worse because I improved uninitialized local checks, so now we're...

This would be nice to catch at some point, we'll need some more complex flow-merging handling if we detect loops that are not skippable. I think it's tricky to decide...

Thanks for the PR, and for looking into Pandas to diagnose our issues! Requesting review from @rchen152 because I think she has the best context on stub bundling - as...

From a bit of poking, the crash appears to be in the `get_module` rdeps insertion check: ``` fn get_module( &self, module: ModuleName, path: Option, ) -> FindingOrError { let require...