Steven Troxler comments

Results 87 comments of


                                            Steven Troxler

Inlay hint insertion should consider imports/use qualified paths

Agreed on most points. I also think cmd-click may actually be possible. When I work on Pyrefly using (open-source, on my macbook) VS Code, the rust inlay hints are indeed...

False positive when a function accepts **kwargs after arguments with default values

Thanks @MaigoAkisame for the detailed report. Function argument matching is pretty tricky to get right, and in general has false negative / false positive tradeoffs (in this particular example the...

`BoundMethod[ReLU, (...) -> Any]` is not assignable to `BoundMethod[ReLU, (self: ReLU, arg: Tensor, /) -> Tensor]`

Thanks for the bug report!

check_type is no longer narrowing types (regression from 0.27.0 -> 0.27.1)

#1635 (closed in favor of this issue) another example of the same problem

Another instance of inconsistent type when breaking cycles

This is already fixed - to be honest I'm not sure when, it seems like the pin should have always been consistent with the result at the end of the...

Another instance of inconsistent type when breaking cycles

Reopening this - the example was fixed but only because a bug in our flow handling moved the narrow outside of the loop Once we put it back in, this...

Incorrect `bad-override` when inheriting from classes with existing `Meta` in django

There's an off-the shelf answer to this, which is that - `Invoice.Meta` must inherit from `DateTimeMixin.Meta` in order to be considered a subclass; this is almost certainly not going to...

How to support env['PYTHONPATH']

If you expect to be able to import `model.risk_request` directly, then the search path you need is probably `'/absolute/path/to/my/project/app'` rather than `'/absolute/path/to/my/project' `

Adding project_excludes config wipes the default directories

Note that this issue implicitly affects `pyrefly init`, although fixing it at the config level might implicitly fix `pyrefly init`

Allow global before variable is defined

Did this come up from an example project? I brought this up after @yangdanny97 patched an internal file using this pattern, but we weren't confident it was worth implementing based...