Steven Troxler

Results 87 comments of Steven Troxler

The actual fix for the reported bug looks like it works to me, and I think it's probably a good thing for `get_method` to return the last definition when there...

Yeah, I can look into adding some CPython unit tests later this week

Issue #164 is now closed, but the fix was specific to TypedDict This is probably related to (perhaps identical to) #793

@DannyGoodall I don't think your bug is the same issue - I suspect it was caused by overload handling, and as far as I can tell it is now fixed,...

The original bug also seems to be fixed - I suspect it may have had to do with union attribute lookups, since `-` desugars to a dunder call.

Just keeping this thread updated: we got Pyrefly working on mypy primer with typeshed injected to the build last weekend. An issue that we will need to work out later...

@yangdanny97 With https://github.com/hauntsaninja/mypy_primer/pull/186, can we close this issue?

[Pyright does not narrow](https://pyright-play.net/?code=CYUwZgBGD20BQA8BcECWA7ALhAPhActOiAJQQC0AfAUSEgFARNqQJoDOE602hxDzQRFCQARgEMATnDJUa-RkKWSQANxDiANgH1MATwAOIRGQgBiCAFtDeiJgAWGANacHqTu7RZFTNgF55ECA) My instinct is that we should not narrow either, at least for now. Even within the same block where a narrowing is in effect, a write...

Whoops removing myself as assignee - I was going to do this during sprints, then I got pulled into other things

I think at this point the issue may be solved. [Looking at the sandbox](https://pyrefly.org/sandbox/?code=MQAg6gpgNgxg9gWwiALnVALZAFAngJwgDMpcQBlAQwDsATAIzgA8AaTASwGcQuRKQADpQDmEAFCgA7lkIhccAK4gYNEJPzsUENpwyVZNWiCgR91PowUpUuAe2rCe5vCgxxqAOgkSQACQgGBsqKAiYgRKYoCoTccEQc3JyGjEwAXD4AtCAA4hDWhJRQGSjsSDYCyDBYMADW9o4REAyUtZkgAKqcyIQAbqZQAPoothAAFACUqOj2nBUw1vYR%2BIRGwxWcbRBMFRpI1NaSmhiYyACSACIAouGR0RDcrpQHyJwKAgJw%2BNajEB7CHnwrHB4AhQnltCBhHBitDaMR7Jp2O42G4%2Bvg2HkYOM2mANFo%2BHQQPgFM5cK53ME4SBaOxCPNSE45Ip8CB6Pg4JIuvgxGIiOyEOV6jxQZ9rAAqHlGAC8IAA3gBfMS0DxvWhPMaygCMqQATPK2JQpTrsb1%2BkMRqNaNilZqQDKFTaVQI1VpRobjWJTYVzRVLZrJkA&version=3.12), we now accept the simple cases ``` d1 = {} d1.update(a=2) reveal_type(d1) d2 = {} d2.update({1:1})...