Istvan Toth

Results 504 comments of Istvan Toth

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _...

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 6m 26s | Docker mode activated. | ||| _ Prechecks _...

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _...

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 6m 10s | Docker mode activated. | ||| _ Prechecks _...

:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 6m 8s | Docker mode activated. | ||| _ Prechecks _...

Regarding the savemode changes: How do other Spark SQL connectors handle Append/Overwrite ? Do you think that accepting both is a good practice ?

> Overwrite mode have'nt been implement respecting Spark definition for this mode. What would the expected behaviour be ?

> It should truncate table and then insert data. > IMO, we should not change actual behavior because it might cause data loss for apps still using the old version...

Also there are still a few unused imports and similar Yetus warnings. Can you clean those up ?