Stone Chen
Stone Chen
Hi @nuomi2021 and @QSXW Thanks for the feedback! I've forced pushed my changes addressing the feedback. > better split to 3 commits > > refact the current code. > add...
> please also cherry pick https://github.com/ffvvc/FFmpeg/tree/workflow to make sure all conformance test passed like https://github.com/ffvvc/FFmpeg/actions/runs/8766181658/job/24058026459?pr=216 I've cherry-picked and pushed the commit
Hi @nuomi2021, I've pushed the suggested change. I've also rebased on the latest ffvvc/up and tested conformance on the latest tests and the failing test passes now locally. ``` dpb_max_num_reorder_pics.266...
Hi @QSXW I received a question on the ML about why not switching on block width inside the asm. I pushed a recent change that adds vvc_sad that merges together...
I've pushed the new version with a single function and merging 16_128 into one code path within. I'll send the updated version to the ML soon-ish
> Should we also add `.` to the label vvc_sad_8 and vvc_sad_16 like .loop_width? The . is syntax for a local label so it feels cleaner to have vvc_sad_8, etc...
> > > Should we also add `.` to the label vvc_sad_8 and vvc_sad_16 like .loop_width? > > > > > > The . is syntax for a local label...
> > > Should we also add `.` to the label vvc_sad_8 and vvc_sad_16 like .loop_width? > > > > > > The . is syntax for a local label...
> > > > > Should we also add `.` to the label vvc_sad_8 and vvc_sad_16 like .loop_width? > > > > > > > > > > > >...
hmm saw the checkasm segfaults on windows .. will need to investigate