Stone Chen

Results 40 comments of Stone Chen

But I will double check this

Hi yeah, seems like I was mistaken, the sub-blocks are constrained pg 235 of the spec ![image](https://github.com/ffvvc/FFmpeg/assets/15571478/5973f830-d703-491c-917b-2b3d1da6c7cb) I will submit a patch though it will be mostly cosmetic since the...

> @stone-d-chen, thank you, > > Before you send the patch, could you add: av_assert0(w == 16 && h == 16 || w == 8 && h == 16 ||...

Great! Switching focus to deblocking now

Hi @nuomi2021, vertical is almost done, just need to fix some issues with 8 bit ``` vvc_v_loop_filter_chroma_10_mix_no-shift_c: 90.2 vvc_v_loop_filter_chroma_10_mix_no-shift_avx: 80.2 vvc_v_loop_filter_chroma_10_mix_shift_c: 140.0 vvc_v_loop_filter_chroma_10_mix_shift_avx: 80.0 vvc_v_loop_filter_chroma_10_one-side_no-shift_c: 150.2 vvc_v_loop_filter_chroma_10_one-side_no-shift_avx: 60.2 vvc_v_loop_filter_chroma_10_one-side_shift_c: 150.2...

Hi, @nuomi2021 should be done now! ``` vvc_v_loop_filter_chroma_8_mix_no-shift_c: 93.8 vvc_v_loop_filter_chroma_8_mix_no-shift_avx: 73.6 vvc_v_loop_filter_chroma_8_mix_shift_c: 143.8 vvc_v_loop_filter_chroma_8_mix_shift_avx: 53.8 vvc_v_loop_filter_chroma_8_one-side_no-shift_c: 223.8 vvc_v_loop_filter_chroma_8_one-side_no-shift_avx: 63.8 vvc_v_loop_filter_chroma_8_one-side_shift_c: 373.8 vvc_v_loop_filter_chroma_8_one-side_shift_avx: 53.8 vvc_v_loop_filter_chroma_8_strong_no-shift_c: 223.8 vvc_v_loop_filter_chroma_8_strong_no-shift_avx: 63.8 vvc_v_loop_filter_chroma_8_strong_shift_c: 333.8 vvc_v_loop_filter_chroma_8_strong_shift_avx:...

Hi @nuomi2021, should I switch to Luma now? versus submitting chroma to the mailing list

@nuomi2021 been looking into further improvements to the luma generation, it seems fairly non-trivial. One of the main issues is occasionally `(d0 1) which is beta_3. It becomes difficult to...

> If it's difficult, perhaps we should approach it as it is. I'll rebase the code to the latest version to fix the fuzz issue. Then, we can work together...

@mlarouche this should be closed now? https://github.com/zigimg/zigimg/pull/275