Bram Stolk

Results 114 comments of Bram Stolk

> I was not proposing to replace the max with a new ternary. I was suggesting moving the pow call down into the existing ternary. As I mentioned, your unit...

I have changed this PR to be less invasive, and only correct the value passed to `powf()` and not the entire pixel value as used in the rest of the...

Can a maintainer please approve the CI run, and then merge? Thanks.

> Hi Bram, what do you think about changing this: > > out[0] = pixel[0] > to this: > > out[0] = pixel[0] > That way it avoids the extra...

The stream that triggers this: The libswresample version on Ubuntu is: ``` ii libswresample-dev:amd64 7:7.1.1-1ubuntu1.2 amd64 FFmpeg library for audio resampling, rematrixing etc. - development files ii libswresample5:amd64 7:7.1.1-1ubuntu1.2 amd64...

> This is beyond my expertiese so I am going to assign it to the lead developer. However, if you could, try downloading v3.4.0-Release-Candidate from openshot.org/download/#daily and see if that...

The code in question that hard-codes the 3D LUT support, is here: https://github.com/OpenShot/libopenshot/blob/develop/src/effects/ColorMap.cpp#L45 ``` if (line.startsWith("LUT_3D_SIZE")) { ``` And no checks for `LUT_1D_SIZE` are made. NOTE: I can attempt to...

NOTE: The Color Map reader also ignores the `DOMAIN_MIN` and `DOMAIN_MAX` values in the `.cube` file.

> Thanks for the bug report! Appreciate it. I'm working on support for both 1D and 3D LUT files. I've got it mostly working now - but adding a few...

Can someone please approve workflows? Also, I've addressed the MR feedback, I think this is ready to get merged.