Christophe Coevoet comments

Results 2839 comments of


                                            Christophe Coevoet

make:entity: public properties instead of private + accessors

For the *inverse* side of relations, where updating the owning side is required, I think it is a good reason to keep using methods to add and remove things. Trying...

Invoker API

@foolip yes, indeed

Invoker API

The name of the feature in the web-features project is still `invoker-commands`, which is why I used "Invoker API" when submitting it. I'm fine with any name for that scope...

Update the README and documentation

@aik099 I cannot. Only @pamil is owner of this organization.

Experiment: Use comparator functions from a global registry for changeset detection

The case of tracking changes for mutable value objects has never been supported by the ORM ever since 2.0. It always required you to clone the object before mutation and...

Switch to attributes instead of annotations

If we bump the min version of Behat, this will indeed be seamless for users.

Update CI workflow to use current versions of PHP and only Symfony versions still under maintenance

the existing workflow fails, so we need to fix things in 2.x, not in 3.x only.

Update CI workflow to use current versions of PHP and only Symfony versions still under maintenance

See my previous comment there: https://github.com/FriendsOfBehat/MinkExtension/pull/38#discussion_r2631956512

[Config] Add `NodeDefinition::docUrl()`

I suggest bumping the min version instead of doing conditional calls. It makes the code simpler

[Config] Add `NodeDefinition::docUrl()`

You should probably also update the dumpers to add a comment with the documentation URL (when present), so that `debug:config` and `config:dump-reference` show it.