MinkExtension icon indicating copy to clipboard operation
MinkExtension copied to clipboard

Update CI workflow to use current versions of PHP and only Symfony versions still under maintenance

Open mpdude opened this issue 2 months ago • 6 comments

mpdude avatar Dec 17 '25 08:12 mpdude

I think it would be much easier if we accept that the workflow is as it is, maybe even with failures for some jobs.

Let’s focus on merging what needs to go into 2.x.

Then agree on minimum requirements for 3.x, drop stuff and clean up the workflow when we have no outdated dependencies getting in our way.

WDYT?

mpdude avatar Dec 19 '25 06:12 mpdude

the existing workflow fails, so we need to fix things in 2.x, not in 3.x only.

stof avatar Dec 19 '25 09:12 stof

The Symfony 4.4 workflow fails because it installs Behat 3.15 with Gherkin 4.16.

Behat 3.15 made particular assumptions about how files are organized inside the Gherkin package, and that broke due to a file reorg in Gherkin.

https://github.com/Behat/Behat/commit/230c0f58cc5412f3fbd068b48336594ec7c38060 fixed the issue for Behat 3.20 and above, but we cannot get that fix (it's Symfony 5.4+).

Seriously, please let's not waste time trying to fix that workflow for Symfony 4.4.

Instead, put all the changes we need into the 2.8 release and raise dependencies to Symfony 5.4 or even above and carry on.

Agree?

mpdude avatar Dec 19 '25 17:12 mpdude

See my previous comment there: https://github.com/FriendsOfBehat/MinkExtension/pull/38#discussion_r2631956512

stof avatar Dec 19 '25 17:12 stof

Please disregard this PR for the time being. Maybe I'll resume here later, maybe I'll close it.

mpdude avatar Dec 19 '25 17:12 mpdude

I don't get it. Could you please make a list which combinations of PHP and Symfony you'd like to see tested on 2.x (2.7?), before we possibly raise requirements in 2.8?

Like so? https://github.com/mpdude/MinkExtension/pull/3/changes

mpdude avatar Dec 19 '25 17:12 mpdude