Steve Sims

Results 33 issues of Steve Sims

The project I'm working on recently adopted connected-react-router, to replace the now defunct react-router-redux. For the most part this was painless, just replacing `import` statements, which was fantastic. We did...

### Current Behavior The HOWTO explaining how to support images, [found here](https://github.com/jaredpalmer/tsdx/issues/379#issuecomment-568239477) does not work for SVGs. I have a `tsdx.config.js` file identical to the one in the HOWTO, but...

scope: integration
solution: needs test

govuk-frontend has several different types of paragraph styles as can be seen here: https://design-system.service.gov.uk/styles/typography/#paragraphs Right now we support a (simple) LeadParagraph component which is styled to match govuk-frontend's `govuk-body-l`, and...

feature
typography

In govuk-frontend there are additional options available for laying out forms with radios and checkboxes. One can have items of conditionally revealed content: https://design-system.service.gov.uk/components/radios/#conditionally-revealing-content https://design-system.service.gov.uk/components/checkboxes/#conditionally-revealing-content And for radios one can...

feature

When attempting to tackle something like #454 it would be good to have instances of the `Header` component complain when they're used, advising that code should be changed to use...

documentation
hoc
deprecation

Some of our tests are testing implementation details, which is bad. For example there are several tests in the ErrorSummary component that recently broke and have been disabled because they...

enhancement
tests

New typography lib has been added that provides standard responsive typography, as per GDS styles in govuk-frontend We need to ensure that our components make use of this, both to...

enhancement
typography

Attempting to set an `id` on a `Paragraph` will silently fail and be ignored. It seems that this is because our component is wrapping react-markdown, which is silently ignoring any...

enhancement
typography

govuk-frontend have just changed the padding in their govuk-main-wrapper mixin. We should change our Page.Main component to match

enhancement
match govuk-frontend

The `FileUpload` component does not currently match govuk-frontend, as it does not have the text "Choose file" in the upload button (the button is currently empty) or "No file chosen"...

enhancement
match govuk-frontend