Steve Sims

Results 31 comments of Steve Sims

We've recently upgraded `withWhiteSpace` so it's now a styling function, providing support for setting both padding and margin in any/all directions. I'd suggest that this requirement could now be handled...

https://github.com/selaux/eslint-plugin-filenames

Adding a `SimpleParagraph` component supporting a font size indicator would be sensible. The current `LeadParagraph` would become a simple wrapper for `SimpleParagraph`, setting appropriate props. The existing `Paragraph` component can...

It may instead be better to remove markdown support from paragraph. Markdown support can be moved to a separate package. `Paragraph` would then become a simpler component that supports the...

Quick update to reflect current thinking. In general ideally we should follow govuk-frontend as closely as practical. In the case of input fields, we made a conscious decision to deviate...

For reference, [stitches](https://stitches.dev) and [vanilla extract](https://vanilla-extract.style) both market themselves as zero-runtime (or near zero-runtime) css-in-js solutions of the two, stitches appears to have an API that is most similar (almost...

Is the `InputField.png` file still needed/used?

we could consider adopting conventional commits. learn publish understands this convention, and will create changelogs accordingly `commitlint` using `@commitlint/config-conventional` with a husky hook to ensure that commits follow the standard...

hmmm - good question - from what I can gather, PRs themselves wouldn't need to be named following the standard, but the squashed commit message would need to be -...

The main problem with this is down to how clicking on one of the error list items is managed. In govuk-react, this was implemented using an `onClick`, whereas govuk-frontend uses...